[Pspp-commits] [SCM] GNU PSPP branch, output, updated. v0.6.1-1046-g97949b7

[Ben Pfaff]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".

The branch, output has been updated
       via  97949b7afde73c20b85ac9040fdead71e01f33b1 (commit)
       via  c53e5d60298cba39cad94ad6daa14e6038a6762c (commit)
       via  c9c6d86621b611f04b9132400ead11681fb9df2b (commit)
       via  23ebdca02083440bb1abc63fc81e0b5d1cdc9f8a (commit)
       via  e2a7ada9e445ab2b1fd473345709c39157f30b9a (commit)
       via  3e30fb40d64fcf006b327a5f81934c14ef842111 (commit)
       via  3917875a58a5c90596639fd6ca3286f8d1ed733a (commit)
      from  b16bbc1f1087ed37f7ba997cbd70cbc5326c38e5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 97949b7afde73c20b85ac9040fdead71e01f33b1
Author: Ben Pfaff <address@hidden>
Date:   Mon Jan 18 22:19:13 2010 -0800

    pspp: Fix interactive usability for multi-line commands.
    
    Until now, the terminal UI has only flushed output just before reading
    the first line of a command.  This generally worked OK because typically
    only the final command produced output, not intermediate lines.  But now
    every line of a command potentially produces output (e.g. the command name
    or the command syntax).  With the ASCII driver that makes the interface
    difficult to use because it typically opens and holds open a pipe to an
    interactive program such as "more", which in turn turns off terminal echo
    etc.
    
    Flushing output before reading each command avoids this problem and makes
    the terminal UI more usable.

commit c53e5d60298cba39cad94ad6daa14e6038a6762c
Author: Ben Pfaff <address@hidden>
Date:   Mon Jan 18 22:10:30 2010 -0800

    ascii: Fix closing pipe files in ascii_destroy().
    
    Files that are opened with fn_open() must be closed with fn_close(), but
    ascii_destroy() wasn't doing that.  This made a particular difference for
    interactive output where fn_close() calls pclose() instead of fclose().

commit c9c6d86621b611f04b9132400ead11681fb9df2b
Author: Ben Pfaff <address@hidden>
Date:   Mon Jan 18 22:09:03 2010 -0800

    ascii: Fix ascii_flush().
    
    ascii_flush() was not actually flushing the contents of the page, so this
    commit changes it to do that.
    
    This change made it clear that the proper place to reset the "y" position
    on the page is in ascii_close_page(), so it makes that change too.

commit 23ebdca02083440bb1abc63fc81e0b5d1cdc9f8a
Author: Ben Pfaff <address@hidden>
Date:   Mon Jan 18 16:10:10 2010 -0800

    message: Fix corner case in msg_emit().
    
    In most cases, msg_emit() initialized the "where" member of the message
    passed in.  However, if msg_init() had not yet been called, it did not do
    this.  This fixes that corner case.
    
    In addition, one caller of msg_emit() did not initialize these members.  It
    is not necessary for both msg_emit() and its callers to do so, but since
    most callers did so, this commit simply makes the remaining caller do so
    as well, for consistency.

commit e2a7ada9e445ab2b1fd473345709c39157f30b9a
Author: Ben Pfaff <address@hidden>
Date:   Mon Jan 18 15:59:56 2010 -0800

    message: Make msg_dup() copy and msg_destroy() free the file name.
    
    This fixes a PSPPIRE bug in its message handling (found by inspection).  It
    makes copies of messages to use later.  The file names were not being
    copied, so in the meantime it was posible that they would be freed,
    yielding a use-after-free error.
    
    Since doing this sensibly required changing the file_name member of
    struct msg_locator from "const char *" to "char *", it also touches up
    places where this caused new warnings.

commit 3e30fb40d64fcf006b327a5f81934c14ef842111
Author: Ben Pfaff <address@hidden>
Date:   Mon Jan 18 15:13:02 2010 -0800

    New library for interned strings.
    
    An "interned" string is stored in a global hash table.  Only one copy of any
    given string is kept in the hash table, which reduces memory usage in cases
    where there might otherwise be many duplicates of a given string.
    
    Interned strings can be compared for equality by comparing pointers, which
    can also be a significant advantage in some cases.
    
    Interned strings are immutable.
    
    This commit adds a general-purpose implementation of interned strings and
    adapts the implementation of value labels, which already had a
    special-purpose and less convenient implementation of interned strings,
    to use them.

commit 3917875a58a5c90596639fd6ca3286f8d1ed733a
Author: Ben Pfaff <address@hidden>
Date:   Mon Jan 18 13:21:24 2010 -0800

    Update Makefile for tests to reflect currently recommended style.
    
    The Autotest example Makefile was recently update to use $(VAR) notation
    instead of @VAR@ notation:
        http://permalink.gmane.org/gmane.comp.sysutils.autoconf.patches/6978
    
    This commit updates tests/automake.mk to follow this new style.

-----------------------------------------------------------------------

Summary of changes:
 src/data/data-in.c                 |    2 +
 src/data/value-labels.c            |  113 +++-------------------------------
 src/data/value-labels.h            |   10 +++-
 src/language/data-io/data-reader.c |    3 +-
 src/libpspp/automake.mk            |    2 +
 src/libpspp/intern.c               |  121 ++++++++++++++++++++++++++++++++++++
 src/libpspp/intern.h               |   41 ++++++++++++
 src/libpspp/message.c              |   25 ++++++--
 src/libpspp/message.h              |    4 +-
 src/libpspp/msg-locator.c          |    5 +-
 src/output/ascii.c                 |   23 ++++---
 src/ui/terminal/read-line.c        |    3 +-
 tests/automake.mk                  |   12 ++--
 13 files changed, 229 insertions(+), 135 deletions(-)
 create mode 100644 src/libpspp/intern.c
 create mode 100644 src/libpspp/intern.h


hooks/post-receive
-- 
GNU PSPP