pspp-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.6.1-1946-g213a


From: Ben Pfaff
Subject: [Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.6.1-1946-g213a9dd
Date: Wed, 23 Mar 2011 04:20:12 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".

The branch, master has been updated
       via  213a9dde780d4b31cdcf7dd14f5015633a89cec5 (commit)
       via  44bce70de3a7d3c2787d0d5cb0b452b5191b38fd (commit)
       via  03bfb72314e434ddaa2ff2b770d1d9df2ea1927a (commit)
       via  763b593a5b5773859e3cf739b843cf0bae0359e5 (commit)
      from  e922b0b490b5721324a230477cecd101c506f79e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 213a9dde780d4b31cdcf7dd14f5015633a89cec5
Author: Ben Pfaff <address@hidden>
Date:   Tue Mar 22 21:20:04 2011 -0700

    i18n: Only close valid iconv converters in i18n_done().
    
    iconv_open() returns (iconv_t) -1 to indicate an error.  We shouldn't
    pass this to iconv_Close().
    
    Reported-by: Jeremy Lavergne <address@hidden>.
    
    John Darrington suggested that this was probably the problem, and
    Jeremy confirmed it with valgrind.

commit 44bce70de3a7d3c2787d0d5cb0b452b5191b38fd
Author: Ben Pfaff <address@hidden>
Date:   Tue Mar 22 21:14:15 2011 -0700

    i18n: Test converting between unknown encodings too.
    
    This would have found the bug fixed by the previous commit.

commit 03bfb72314e434ddaa2ff2b770d1d9df2ea1927a
Author: Ben Pfaff <address@hidden>
Date:   Tue Mar 22 20:55:55 2011 -0700

    str: Make ss_alloc_substring_pool() null-terminate its output.
    
    It's inconsistent that ss_alloc_substring() null-terminates its output
    but ss_alloc_substring_pool() does not.  This caught us out in
    recode_substring_pool(), which used ss_alloc_substring_pool() in a
    fallback case where create_iconv() failed and expected the result to
    be null-terminated.
    
    Reported-by: Jeremy Lavergne <address@hidden>

commit 763b593a5b5773859e3cf739b843cf0bae0359e5
Author: Ben Pfaff <address@hidden>
Date:   Tue Mar 22 21:12:11 2011 -0700

    tests: Wrap more binaries for "check-valgrind" target.

-----------------------------------------------------------------------

Summary of changes:
 src/libpspp/i18n.c    |    3 ++-
 src/libpspp/str.c     |    7 ++++---
 tests/automake.mk     |   28 ++++++++++++++++++++++++++--
 tests/libpspp/i18n.at |    8 ++++++++
 4 files changed, 40 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
GNU PSPP



reply via email to

[Prev in Thread] Current Thread [Next in Thread]