[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v1.6.2-230-g505a0
From: |
Ben Pfaff |
Subject: |
[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v1.6.2-230-g505a04fe4 |
Date: |
Sat, 22 Apr 2023 21:09:25 -0400 (EDT) |
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".
The branch, master has been updated
via 505a04fe4cf5cb6f81b498e997898e6069387791 (commit)
from 27b725e6d02cbea19b1435ffbaaa9ef5e87f0435 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 505a04fe4cf5cb6f81b498e997898e6069387791
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Sat Apr 22 18:05:44 2023 -0700
Fix checks for valid integer range subset of 'double'.
Previously, I assumed that checking that a 'double' was between LONG_MIN
and LONG_MAX meant that it would convert to a sensible 'long'. This is
wrong, because LONG_MAX rounds up to a higher 'double', because it has too
many bits for a 53-bit mantissa. This could cause problems, like for
example LONG_MAX (as a double) turns out to convert back to LONG_MIN (as a
'long'). This commit fixes the problem.
Thanks to Youngseok Choi for reporting the problem.
Reported at
https://lists.gnu.org/archive/html/bug-gnu-pspp/2023-04/msg00005.html.
-----------------------------------------------------------------------
Summary of changes:
src/language/commands/matrix.c | 43 ++++++++++++++++++++++++-------
src/language/lexer/lexer.c | 4 +++
src/language/lexer/token.c | 11 +++++---
src/libpspp/automake.mk | 1 +
src/libpspp/float-range.h | 53 +++++++++++++++++++++++++++++++++++++++
tests/language/commands/matrix.at | 34 ++++++++++++++++++++++++-
6 files changed, 132 insertions(+), 14 deletions(-)
create mode 100644 src/libpspp/float-range.h
hooks/post-receive
--
GNU PSPP
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Pspp-commits] [SCM] GNU PSPP branch, master, updated. v1.6.2-230-g505a04fe4,
Ben Pfaff <=