Re: cleaned up VLS support

[John Darrington]

On Sat, May 06, 2006 at 07:30:50PM -0700, Ben Pfaff wrote:
     I happened to be looking at my pspp-cvs folder just when your
     commit happened.  Thanks for reworking that.  It looks much
     better.  I do have a couple of additional comments:
     
             * Now width_to_bytes() is only used in the
               sys-file-reader/writer, could it be moved into one of
               those files (or create a new one for common code)?

Yes.  I did consider that.  Perhaps declare the in sfm-private.h ?
     
             * compare_var_shortnames() and hash_var_shortname() are
               complex, but I don't understand why they can't just
               call, respectively, strcmp() and hsh_hash_string().  Is
               something tricky going on?

That's how they were originally, and valgrind showed up some read
errors.  The problem is, that shortnames are not necessarily null
terminated, which complicates things.

J'
     

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

pgpBuKWIaeaOL.pgp
Description: PGP signature