Re: [patch #5498] Add integer, floating point, and character recoding routines

[John Darrington]

I can't see any major problems .

1. There are some  string g literals which need to be placed withing
_(...) for the  benefit of gettext.

2. I'm a bit concerned at  how usable this is :

/* Renders SRC, which contains SIZE bytes of a floating-point
+   number in the given FORMAT, as relatively human-readable
+   null-terminated string in DST, which must be large enough to
+   hold the output. */
+static void
+make_printable (enum float_format format, const void *src_,
+                char *dst, size_t size) 

How am  I supposed to know how large DST should be, a priori? ? Does
it have safe behaviour  if it's not large enough?   The function does
not return an error code.

J'



On Fri, Oct 27, 2006 at 03:27:35AM +0000, Ben Pfaff wrote:
     
     The attached patch adds routines for integer byte order conversions, 
floating
     point format and byte order conversions, and ASCII<->EBCDIC conversion.  It
     also adds an extensive floating point format conversion test.  It is mainly
     new files.
     
     The ASCII<->EBCDIC conversion used by SPSS does not correspond exactly to 
any
     found in GNU libiconv, hence the need for a separate library.
     
     These routines are a small part of a larger change set that I'm breaking up
     for gradual submission.  Thus, they aren't used by much yet.
     
5A
-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

signature.asc
Description: Digital signature