[patch #5562] line-buffer / getl_ reorganisation

[Ben Pfaff]

Update of patch #5562 (project pspp):

                  Status:   Ready For Test/Review => Works For Me           
             Assigned to:                     blp => jmd                    

    _______________________________________________________

Follow-up Comment #3:

I'm pretty happy with this.  Nit-picking follows:

In prompt.[ch], could the functions be renamed to put "prompt" at the
beginning?  e.g. get_prompt_style -> prompt_get_style and so on.  This
would make it clear at a glance that they come from a module named
"prompt".

I think that the function source is only used in DO REPEAT.  I wonder
whether it should be merged in with it.  It seems like the
function_source is a really thin wrapper around getl_interface now; it
was less apparently "thin" before, because it *was* the exposed
interface.  If you don't like merging it, could the source file be
named something less generic?  Maybe "function-source.c"?


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?5562>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/