[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch 10/19] new function value_cnt_from_width
From: |
Ben Pfaff |
Subject: |
Re: [patch 10/19] new function value_cnt_from_width |
Date: |
Wed, 06 Jun 2007 22:46:02 -0700 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) |
Someday that may be a good idea but for now the definition of
struct variable is only in variable.c not in variable.h.
John Darrington <address@hidden> writes:
> Perhaps var_get_value_cnt could be inline
>
> On Tue, Jun 05, 2007 at 11:27:37PM -0700, address@hidden wrote:
> Index: merge/src/data/variable.c
> ===================================================================
> --- merge.orig/src/data/variable.c 2007-06-03 18:44:51.000000000
> -0700
> +++ merge/src/data/variable.c 2007-06-04 21:31:31.000000000 -0700
> @@ -423,7 +423,7 @@
> size_t
> var_get_value_cnt (const struct variable *v)
> {
> - return v->width == 0 ? 1 : DIV_RND_UP (v->width, MAX_SHORT_STRING);
> + return value_cnt_from_width (v->width);
> }
>
> /* Returns variable V's missing values. */
--
Ben Pfaff
address@hidden
- Re: [patch 12/19] make aux_data static in libpspp tests, (continued)
- [patch 19/19] i18n changes to Smake, configure.ac, blp, 2007/06/06
- [patch 08/19] case_ordering implementation, blp, 2007/06/06
- [patch 11/19] fix assertion in binary_search, blp, 2007/06/06
- [patch 18/19] fairly experimental changes based on what seemed to make sense, blp, 2007/06/06
- [patch 10/19] new function value_cnt_from_width, blp, 2007/06/06
- [patch 02/19] new function get_workspace_cases, blp, 2007/06/06
- [patch 06/19] sliding window of cases, blp, 2007/06/06
- [patch 04/19] temporary file for array of cases, blp, 2007/06/06
- [patch 09/19] casegrouper implementation, blp, 2007/06/06
- [patch 01/19] move casenumber to case.h, blp, 2007/06/06