Re: psql-reader null pointer dereference?

[John Darrington]

One thing is for sure: that code could use some more comments.

The analyser is correct.  A null pointer dereference could potentially
occur if the PSQL library server started behaving oddly.  However, this
feature has some quite comprehensive tests, and there's been no problem 
so far.

I suggest that we raise a bug about this, so that I can fix it when I 
get time.

J'

On Thu, Feb 12, 2010 at 10:28:35PM -0800, Ben Pfaff wrote:
     I ran clang-analyzer (http://clang-analyzer.llvm.org) on the PSPP
     source tree and here is the report:
             http://benpfaff.org:8181/
     
     Some of the reports are correct.  Others are false positives.  I
     am not sure about the ones for psql-reader.c (which are all quite
     similar):
             http://benpfaff.org:8181/report-5PvYYA.html#EndPath
             http://benpfaff.org:8181/report-sP82Pb.html#EndPath
             http://benpfaff.org:8181/report-nSLyIM.html#EndPath
             http://benpfaff.org:8181/report-h6avCn.html#EndPath
     
     They look plausible but I don't understand the code well enough
     to say for sure.  Can you take a look at those (and any others
     that you would like to)?
     -- 
     "The sound of peacocks being shredded can't possibly be
      any worse than the sound of peacocks not being shredded."
     Tanuki the Raccoon-dog in the Monastery

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

signature.asc
Description: Digital signature