Re: [encodings 0/4] Improve support for input encodings

[John Darrington]

This all looks fine to me.

On Tue, Jun 19, 2012 at 11:11:33PM -0700, Ben Pfaff wrote:
     This has been cooking for some time but I was spurred to finish it
     up by this recent Debian bug report:
        http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=676371
     
     Ben Pfaff (4):
       PRINT SPACE: Fix missing fh_unref() on error path.
       line-reader: New library for reading a file line-by-line.
       Add ENCODING subcommand to several commands.
       text-data-import-dialog: Allow user to choose input encoding.
     
      NEWS                                   |    3 +-
      doc/data-io.texi                       |   47 ++++-
      doc/files.texi                         |    5 +
      src/data/file-handle-def.c             |   30 ++--
      src/data/file-handle-def.h             |    4 +-
      src/language/data-io/data-list.c       |   13 +-
      src/language/data-io/data-parser.c     |    6 +-
      src/language/data-io/data-reader.c     |  129 +++++++++----
      src/language/data-io/data-reader.h     |    7 +-
      src/language/data-io/data-writer.c     |   50 ++++-
      src/language/data-io/data-writer.h     |    7 +-
      src/language/data-io/file-handle.q     |   16 +-
      src/language/data-io/get-data.c        |   20 ++-
      src/language/data-io/inpt-pgm.c        |   35 +++-
      src/language/data-io/print-space.c     |   38 +++--
      src/language/data-io/print.c           |   16 ++-
      src/libpspp/automake.mk                |    2 +
      src/libpspp/line-reader.c              |  350 
++++++++++++++++++++++++++++++++
      src/libpspp/line-reader.h              |   54 +++++
      src/ui/gui/text-data-import-dialog.c   |   60 ++++--
      tests/automake.mk                      |    5 +
      tests/language/data-io/get-data-txt.at |   17 ++
      tests/libpspp/line-reader-test.c       |  130 ++++++++++++
      tests/libpspp/line-reader.at           |   74 +++++++
      24 files changed, 976 insertions(+), 142 deletions(-)
      create mode 100644 src/libpspp/line-reader.c
      create mode 100644 src/libpspp/line-reader.h
      create mode 100644 tests/libpspp/line-reader-test.c
      create mode 100644 tests/libpspp/line-reader.at
     
     -- 
     1.7.2.5
     
     
     _______________________________________________
     pspp-dev mailing list
     address@hidden
     https://lists.gnu.org/mailman/listinfo/pspp-dev

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.

signature.asc
Description: Digital signature