[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/5] var-type-dialog: Use G_TYPE_INT to store an int.
From: |
Ben Pfaff |
Subject: |
[PATCH 3/5] var-type-dialog: Use G_TYPE_INT to store an int. |
Date: |
Mon, 16 Jul 2012 23:45:54 -0700 |
It seems more straightforward to store an int by value than by
pointer.
---
src/ui/gui/var-type-dialog.c | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/ui/gui/var-type-dialog.c b/src/ui/gui/var-type-dialog.c
index aa46ca4..4ed27f0 100644
--- a/src/ui/gui/var-type-dialog.c
+++ b/src/ui/gui/var-type-dialog.c
@@ -314,7 +314,7 @@ set_format_type_from_treeview (GtkTreeView *treeview,
gpointer data)
gtk_tree_model_get_value (model, &iter, 1, &the_value);
dialog->fmt_l = custom_format;
- dialog->fmt_l.type = *(int*) g_value_get_pointer (&the_value);
+ dialog->fmt_l.type = g_value_get_int (&the_value);
g_value_unset (&the_value);
}
@@ -500,8 +500,7 @@ var_type_dialog_create (GtkWindow *toplevel)
column);
- list_store = gtk_list_store_new (2, G_TYPE_STRING,
- G_TYPE_POINTER);
+ list_store = gtk_list_store_new (2, G_TYPE_STRING, G_TYPE_INT);
for ( i = 0 ; i < 5 ; ++i )
{
@@ -509,7 +508,7 @@ var_type_dialog_create (GtkWindow *toplevel)
gtk_list_store_append (list_store, &iter);
gtk_list_store_set (list_store, &iter,
0, fmt_name (cc_fmts[i]),
- 1, &cc_format[i],
+ 1, cc_format[i],
-1);
}
@@ -640,7 +639,7 @@ select_treeview_from_format_type (GtkTreeView *treeview,
gtk_tree_model_get_value (model, &iter, 1, &value);
- spec = * ((int *) g_value_get_pointer (&value));
+ spec = g_value_get_int (&value);
g_value_unset (&value);
--
1.7.2.5
- [PATCH 0/5] more var-type-dialog improvements, Ben Pfaff, 2012/07/17
- [PATCH 1/5] var-type-dialog: Avoid string copy setting up currency treeview., Ben Pfaff, 2012/07/17
- [PATCH 2/5] var-type-dialog: Fix possible memory leaks., Ben Pfaff, 2012/07/17
- [PATCH 4/5] format: Make fmt_date_template() human-friendly, respect field width., Ben Pfaff, 2012/07/17
- [PATCH 5/5] var-type-dialog: Use fmt_date_template() to reduce duplication., Ben Pfaff, 2012/07/17
- [PATCH 3/5] var-type-dialog: Use G_TYPE_INT to store an int.,
Ben Pfaff <=
- Re: [PATCH 0/5] more var-type-dialog improvements, John Darrington, 2012/07/17