Re: new compiler warning under "wheezy" in Perl code

[John Darrington]

On Sun, Sep 09, 2012 at 05:15:59PM -0700, Ben Pfaff wrote:
     I upgraded from Debian "squeeze" to "wheezy" this week and there
     are tons of new warnings now.  Most of them are not real
     problems, so I can resolve them, but this one seems like a real
     problem and I don't know the correct fix:
     
     PSPP.xs: In function 'XS_PSPP__Sysfile_pxs_create_sysfile':
     PSPP.xs:577:28: warning: cast to pointer from integer of different size 
[-Wint-to-pointer-cast]
     
     Would you mind taking a look?
     
Can you try this patch:

index 834ec40..a66f442 100644
--- a/perl-module/PSPP.xs
+++ b/perl-module/PSPP.xs
@@ -568,13 +568,12 @@ MODULE = PSPP             PACKAGE = PSPP::Sysfile
 
 
 struct sysfile_info *
-pxs_create_sysfile (name, dict_ref, opts_hr)
+pxs_create_sysfile (name, dict, opts_hr)
  char *name
- SV *dict_ref
+ struct dictionary *dict;
  SV *opts_hr
 INIT:
- SV *dict_sv = SvRV (dict_ref);
- struct dictionary *dict = (void *) SvIV (dict_sv);
+ SV *dict_sv = ST(1);
  struct sfm_write_options opts;
  if (!SvROK (opts_hr))
   {


-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.

signature.asc
Description: Digital signature