[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug37999 04/11] RANK: Lowercase the name of "enum RANK_FUNC".
From: |
Ben Pfaff |
Subject: |
[bug37999 04/11] RANK: Lowercase the name of "enum RANK_FUNC". |
Date: |
Thu, 31 Jan 2013 22:03:26 -0800 |
It is fairly unusual to give a type an all-uppercase name. The name looks
more natural to me in lowercase.
---
src/language/stats/rank.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/language/stats/rank.c b/src/language/stats/rank.c
index 06e7e9f..fd57038 100644
--- a/src/language/stats/rank.c
+++ b/src/language/stats/rank.c
@@ -81,7 +81,7 @@ static double rank_ntiles (const struct rank *, double c,
double cc, double cc_1
int i, double w);
-enum RANK_FUNC
+enum rank_func
{
RANK,
NORMAL,
@@ -146,7 +146,7 @@ enum fraction
struct rank_spec
{
- enum RANK_FUNC rfunc;
+ enum rank_func rfunc;
struct variable **destvars;
};
@@ -157,7 +157,7 @@ struct rank_spec
If VNAME is NULL, then a name will be automatically chosen.
*/
static struct variable *
-create_rank_variable (struct dictionary *dict, enum RANK_FUNC f,
+create_rank_variable (struct dictionary *dict, enum rank_func f,
const struct variable *src_var,
const char *vname)
{
@@ -626,7 +626,7 @@ fraction_name (const struct rank *cmd)
/* Create a label on DEST_VAR, describing its derivation from SRC_VAR and F */
static void
create_var_label (struct rank *cmd, struct variable *dest_var,
- const struct variable *src_var, enum RANK_FUNC f)
+ const struct variable *src_var, enum rank_func f)
{
struct string label;
ds_init_empty (&label);
--
1.7.10.4
- [bug37999 00/11] Make RANK work with TEMPORARY., Ben Pfaff, 2013/02/01
- [bug37999 01/11] casegrouper: Add comments., Ben Pfaff, 2013/02/01
- [bug37999 04/11] RANK: Lowercase the name of "enum RANK_FUNC".,
Ben Pfaff <=
- [bug37999 05/11] RANK: Remove write-only struct member 'ascending'., Ben Pfaff, 2013/02/01
- [bug37999 03/11] transformations: Relax the rules for transformation finalizing., Ben Pfaff, 2013/02/01
- [bug37999 06/11] RANK: Put #include directives into typical order., Ben Pfaff, 2013/02/01
- [bug37999 02/11] subcase: New function subcase_add_vars_always()., Ben Pfaff, 2013/02/01
- [bug37999 07/11] RANK: Simplify fraction_name() function., Ben Pfaff, 2013/02/01
- [bug37999 08/11] RANK: Simplify rank_sorted_file() with new function sum_weights()., Ben Pfaff, 2013/02/01
- [bug37999 09/11] RANK: Create all variables together, in order., Ben Pfaff, 2013/02/01