Re: [PATCH 2/5] Ensure all lex_readers have the encoding parameter

[John Darrington]

On Thu, Oct 08, 2015 at 09:26:42PM -0700, Ben Pfaff wrote:
     On Thu, Oct 08, 2015 at 09:21:39PM -0700, Ben Pfaff wrote:
     > 
     > This yields a new warning:
     > 
     >     ../src/data/file-handle-def.c: In function 'fh_create_file':
     >     ../src/data/file-handle-def.c:230:68: error: unused parameter 
'file_name_encoding' [-Werror=unused-parameter]


Right.  This is because the new parameter I have added is indeed unused (it 
wouldn't be if the printf below
was uncommented :P )  This new parameter will however be needed to fix the 
bigger issue.


     > 
     > I'd prefer not to add commented-out code, as here:
     > 
     >  {
     >    char *handle_name;
     >    struct file_handle *handle;
     >  
     > +  //  printf ("%s:%d Creating file handle for file %s with encoding 
%s\n", __FILE__, __LINE__, file_name, file_name_encoding);

Thanks for noticing.  I'll remove it.

     
     Actually, this causes build failures in the Perl module:

I wonder why I didn't see that.  I will investigate and fix it.
     
     PSPP.xs: In function ???XS_PSPP__Sysfile_pxs_create_sysfile???:
     PSPP.xs:641:31: warning: passing argument 3 of ???fh_create_file??? from 
incompatible pointer type
        fh_create_file (NULL, name, fh_default_properties () );
                                    ^
                          ^

J'

-- 
Avoid eavesdropping.  Send strong encryted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

signature.asc
Description: Digital signature