[patch #9777] Added gui support for some POSTHOC tests for One Way ANOVA

[John Darrington]

Update of patch #9777 (project pspp):

                  Status:                    None => In Progress            

    _______________________________________________________

Follow-up Comment #6:

Sorry for the confusion.  Hopefully I'm looking at the right patch
now.  There are a few issues with it:


1.  These macros:

#define     POSTHOC_BONFERRONI  0x01
#define     POSTHOC_GH          0x02
#define     POSTHOC_LSD         0x03
#define     POSTHOC_SCHEFFE     0x04
#define     POSTHOC_SIDAK       0x05
#define     POSTHOC_TUKEY       0x06

You are using as bit fields, but you have defined their values as
sequential integers.  You must define them as unique bit values
otherwise they will interfere with each other.

2. In the GUI, you have put all the options in upper case.  It looks
better to write "Tukey HSD" rather than "TUKEY HSD".   Also please
make sure that the diacritics are correct
(refer to https://en.wikipedia.org/w/index.php?title=Sidak_correction and
       https://en.wikipedia.org/w/index.php?title=Scheffe_method)

3. Do you think the Contrasts and PostHoc buttons would be better
packed vertically rather than horizontally?

4. Minor nit:

Comments like /*Posthoc button */ should normally be written with a
space, like /* Posthoc button */


Perhaps you could make these corrections and send a new patch.

Thanks

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9777>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/