[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemacs-devel] [PATCH] Shut up valgrind
|
From: |
François Revol |
|
Subject: |
Re: [Qemacs-devel] [PATCH] Shut up valgrind |
|
Date: |
Thu, 23 Jan 2014 14:40:07 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130630 Icedove/17.0.7 |
On 23/01/2014 14:02, Charles Gordon wrote:
> Hi Francois,
>
> I just committed a large patch to fix this issue among other malloc related
> inconsistencies.
> valgrind was right, it was a bug!
> qe_mallocz would have cleared the allocated structure, but you used malloc in
> haiku.cpp to allocate it :(
> valgrind rules!
Actually I ran it on GNU/Linux since valgrind isn't available yet on
Haiku... (I just started the port).
The X11 code did use qe_mallocz, but I didn't check the tty code though.
> I added macros to prevent spurious uses of malloc/free.
> Can you verify the I did not break the compilation?
Works on Debian here.
On Haiku I had to change some atomic calls since the API has been
modified recently, but the rest seems ok.
François.