Re: [Qemu-arm] [PATCH 02/42] target/arm: Add stubs for AArch32 VFP decodetree

[Richard Henderson]

On 6/6/19 12:45 PM, Peter Maydell wrote:
> Add the infrastructure for building and invoking a decodetree decoder
> for the AArch32 VFP encodings.  At the moment the new decoder covers
> nothing, so we always fall back to the existing hand-written decode.
> 
> We need to have one decoder for the unconditional insns and one for
> the conditional insns, as otherwise the patterns for conditional
> insns would incorrectly match against the unconditional ones too.
> 
> Since translate.c is over 14,000 lines long and we're going to be
> touching pretty much every line of the VFP code as part of the
> decodetree conversion, we create a new translate-vfp.inc.c to hold
> the code which deals with VFP in the new scheme.  It should be
> possible to convert this into a standalone translation unit
> eventually, but the conversion process will be much simpler if we
> simply #include it midway through translate.c to start with.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  target/arm/Makefile.objs       | 13 +++++++++++++
>  target/arm/translate-vfp.inc.c | 31 +++++++++++++++++++++++++++++++
>  target/arm/translate.c         | 19 +++++++++++++++++++
>  target/arm/vfp-uncond.decode   | 28 ++++++++++++++++++++++++++++
>  target/arm/vfp.decode          | 28 ++++++++++++++++++++++++++++
>  5 files changed, 119 insertions(+)
>  create mode 100644 target/arm/translate-vfp.inc.c
>  create mode 100644 target/arm/vfp-uncond.decode
>  create mode 100644 target/arm/vfp.decode

Reviewed-by: Richard Henderson <address@hidden>


r~