Re: [Qemu-arm] [PATCH 09/42] target/arm: Convert VCVTA/VCVTN/VCVTP/VCVTM to decodetree

[Peter Maydell]

On Fri, 7 Jun 2019 at 16:38, Richard Henderson
<address@hidden> wrote:
>
> On 6/6/19 12:45 PM, Peter Maydell wrote:
> > @@ -3452,6 +3446,15 @@ static int disas_vfp_insn(DisasContext *s, uint32_t 
> > insn)
> >          }
> >      }
> >
> > +    if (extract32(insn, 28, 4) == 0xf) {
> > +        /*
> > +         * Encodings with T=1 (Thumb) or unconditional (ARM): these
> > +         * were all handled by the decodetree decoder, so any insn
> > +         * patterns which get here must be UNDEF.
> > +         */
> > +        return 1;
> > +    }
>
> This could be merged into the previous IF.  Unless I'm jumping the gun and 
> this
> too goes away at the end after everything is converted?

Yes, it goes away in patch 41 when we delete the no-longer-used
skeleton of the legacy decoder.

thanks
-- PMM