[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 28/42] target/arm: Convert VMOV (imm) to decodetre
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [PATCH 28/42] target/arm: Convert VMOV (imm) to decodetree |
Date: |
Mon, 10 Jun 2019 11:40:03 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/10/19 10:12 AM, Peter Maydell wrote:
> On Sat, 8 Jun 2019 at 20:29, Richard Henderson
> <address@hidden> wrote:
>>
>> On 6/6/19 12:45 PM, Peter Maydell wrote:
>>> + n = (a->imm4h << 28) & 0x80000000;
>>> + i = ((a->imm4h << 4) & 0x70) | a->imm4l;
>>> + if (i & 0x40) {
>>> + i |= 0x780;
>>> + } else {
>>> + i |= 0x800;
>>> + }
>>> + n |= i << 19;
>>
>> Can we reuse vfp_expand_imm here? Given that you don't have pure code motion
>> from the old code (due to field extraction) it doesn't feel wrong to go ahead
>> and fix this wart now.
>
> I dunno, I'd kind of prefer to do it later. We're already
> drifting away from the old code as you say, and going
> straight to vfp_expand_imm() makes it even less clear that
> we're doing the same thing the old code was...
Fair enough.
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [Qemu-arm] [PATCH 03/42] target/arm: Factor out VFP access checking code, (continued)
[Qemu-arm] [PATCH 15/42] target/arm: Convert VFP VLDR and VSTR to decodetree, Peter Maydell, 2019/06/06
[Qemu-arm] [PATCH 25/42] target/arm: Convert VSUB to decodetree, Peter Maydell, 2019/06/06
[Qemu-arm] [PATCH 32/42] target/arm: Convert VMOV (register) to decodetree, Peter Maydell, 2019/06/06
[Qemu-arm] [PATCH 33/42] target/arm: Convert VFP comparison insns to decodetree, Peter Maydell, 2019/06/06
[Qemu-arm] [PATCH 07/42] target/arm: Convert VMINNM, VMAXNM to decodetree, Peter Maydell, 2019/06/06