qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation


From: Laurent Vivier
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on
Date: Wed, 12 Jun 2019 09:40:43 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0

Le 12/06/2019 à 06:27, Ramon Fried a écrit :
> 
> 
> On Tue, Jun 11, 2019 at 7:21 PM Laurent Vivier <address@hidden
> <mailto:address@hidden>> wrote:
> 
>     Le 11/06/2019 à 16:55, Ramon Fried a écrit :
>     > defining CADENCE_GEM_ERR_DEBUG causes compilation
>     > errors, fix that.
>     >
>     > Signed-off-by: Ramon Fried <address@hidden
>     <mailto:address@hidden>>
>     > ---
>     > v2: change %lx to HWADDR_PRIx and %lx to %zdx
> 
>     HWADDR_PRIx is to use with hwaddr type (packet_desc_addr).
>     rx_desc_get_buffer() is uint64_t, you must use PRIx64.
>     It may be better to remove also the cast to unsigned.
> 
> Other places in the code also use HWADDR_PRIx with  rx_desc_get_buffer().
> Should I change them also ?

No, in fact you should change the return type of rx_desc_get_buffer() to
hwaddr.

Thanks,
Laurent



reply via email to

[Prev in Thread] Current Thread [Next in Thread]