|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [Qemu-arm] [PATCH v2 18/23] target/arm: Move CPU state dumping routines to helper.c |
Date: | Mon, 17 Jun 2019 16:45:37 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 6/17/19 4:41 PM, Alex Bennée wrote: > > Philippe Mathieu-Daudé <address@hidden> writes: > >> From: Samuel Ortiz <address@hidden> >> >> They're not TCG specific and should be living the generic helper file >> instead. >> >> Signed-off-by: Samuel Ortiz <address@hidden> >> Reviewed-by: Robert Bradford <address@hidden> >> [PMD: Rebased] >> Signed-off-by: Philippe Mathieu-Daudé <address@hidden> >> --- >> target/arm/helper.c | 214 >> +++++++++++++++++++++++++++++++++++++ > > Hmm so helper is a mix of non-TCG and TCG bits whereas helper-a64.c is > basically just TCG helpers. It makes me wonder if we are breaking a > convention here as helper.c is traditionally only TCG helpers. > > It feels like there should be different file that is unambiguously used > for both TCG and KVM based workloads where things like the cpu dump code > can live. Good idea. What about target/arm/arch_dump.c? >> target/arm/internals.h | 8 ++ >> target/arm/translate-a64.c | 127 ---------------------- >> target/arm/translate.c | 87 --------------- >> target/arm/translate.h | 5 - >> 5 files changed, 222 insertions(+), 219 deletions(-)
[Prev in Thread] | Current Thread | [Next in Thread] |