[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH] hw/arm/msf2-som: Exit when the cpu is not the exp
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-arm] [PATCH] hw/arm/msf2-som: Exit when the cpu is not the expected one |
|
Date: |
Mon, 17 Jun 2019 14:20:13 -0300 |
On Mon, Jun 17, 2019 at 06:01:36PM +0200, Philippe Mathieu-Daudé wrote:
> This machine correctly defines its default_cpu_type to cortex-m3
> and report an error if the user requested another cpu_type,
> however it does not exit, and this can confuse users trying
> to use another core:
>
> $ qemu-system-arm -M emcraft-sf2 -cpu cortex-m4 -kernel test-m4.elf
> qemu-system-arm: This board can only be used with CPU cortex-m3-arm-cpu
> [output related to M3 core ...]
>
> The CPU is indeed a M3 core:
>
> (qemu) info qom-tree
> /machine (emcraft-sf2-machine)
> /unattached (container)
> /device[0] (msf2-soc)
> /armv7m (armv7m)
> /cpu (cortex-m3-arm-cpu)
>
> Add the missing exit() call to return to the shell.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
--
Eduardo