[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 5/6] hw/timer/armv7m_systick: Forbid
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 5/6] hw/timer/armv7m_systick: Forbid non-privileged accesses |
Date: |
Mon, 17 Jun 2019 13:03:04 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/17/19 10:53 AM, Peter Maydell wrote:
> Like most of the v7M memory mapped system registers, the systick
> registers are accessible to privileged code only and user accesses
> must generate a BusFault. We implement that for registers in
> the NVIC proper already, but missed it for systick since we
> implement it as a separate device. Correct the omission.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/timer/armv7m_systick.c | 26 ++++++++++++++++++++------
> 1 file changed, 20 insertions(+), 6 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-arm] [PATCH 0/6] Six minor M-profile bugfixes, Peter Maydell, 2019/06/17
- [Qemu-arm] [PATCH 2/6] arm v8M: Forcibly clear negative-priority exceptions on deactivate, Peter Maydell, 2019/06/17
- [Qemu-arm] [PATCH 3/6] target/arm: v8M: Check state of exception being returned from, Peter Maydell, 2019/06/17
- [Qemu-arm] [PATCH 6/6] target/arm: Execute Thumb instructions when their condbits are 0xf, Peter Maydell, 2019/06/17
- [Qemu-arm] [PATCH 4/6] target/arm: Use _ra versions of cpu_stl_data() in v7M helpers, Peter Maydell, 2019/06/17
- [Qemu-arm] [PATCH 5/6] hw/timer/armv7m_systick: Forbid non-privileged accesses, Peter Maydell, 2019/06/17
- [Qemu-arm] [PATCH 1/6] target/arm: NS BusFault on vector table fetch escalates to NS HardFault, Peter Maydell, 2019/06/17