Re: [Qemu-arm] [Qemu-devel] [PATCH 2/5] i.mx7d: Add no-op/unimplemented PCIE PHY IP block

[Philippe Mathieu-Daudé]

On 4/16/19 3:38 AM, Andrey Smirnov wrote:
> Add no-op/unimplemented PCIE PHY IP block. Needed by new kernels to
> use PCIE.
> 
> Signed-off-by: Andrey Smirnov <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: Michael S. Tsirkin <address@hidden>
> Cc: address@hidden
> Cc: address@hidden
> ---
>  include/hw/arm/fsl-imx7.h | 3 +++
>  hw/arm/fsl-imx7.c         | 5 +++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/include/hw/arm/fsl-imx7.h b/include/hw/arm/fsl-imx7.h
> index aae4f860fc..3efa697adc 100644
> --- a/include/hw/arm/fsl-imx7.h
> +++ b/include/hw/arm/fsl-imx7.h
> @@ -125,6 +125,9 @@ enum FslIMX7MemoryMap {
>      FSL_IMX7_ADC2_ADDR            = 0x30620000,
>      FSL_IMX7_ADCn_SIZE            = 0x1000,
>  
> +    FSL_IMX7_PCIE_PHY_ADDR        = 0x306D0000,
> +    FSL_IMX7_PCIE_PHY_SIZE        = 0x10000,
> +
>      FSL_IMX7_GPC_ADDR             = 0x303A0000,
>  
>      FSL_IMX7_I2C1_ADDR            = 0x30A20000,
> diff --git a/hw/arm/fsl-imx7.c b/hw/arm/fsl-imx7.c
> index 1abfa5910c..813fb55ca9 100644
> --- a/hw/arm/fsl-imx7.c
> +++ b/hw/arm/fsl-imx7.c
> @@ -532,6 +532,11 @@ static void fsl_imx7_realize(DeviceState *dev, Error 
> **errp)
>       */
>      create_unimplemented_device("dma-apbh", FSL_IMX7_DMA_APBH_ADDR,
>                                  FSL_IMX7_DMA_APBH_SIZE);
> +    /*
> +     * PCIe PHY
> +     */
> +    create_unimplemented_device("pcie-phy", FSL_IMX7_PCIE_PHY_ADDR,
> +                                FSL_IMX7_PCIE_PHY_SIZE);
>  }
>  
>  static void fsl_imx7_class_init(ObjectClass *oc, void *data)
> 

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>