Re: [Qemu-arm] [PATCH 0/2] Add Aspeed GPIO controller model

[Cédric Le Goater]

On 18/06/2019 10:51, Rashmica Gupta wrote:
> Hi,
> 
> These two patches add a bunch of the functionality of the ast2400 and
> ast2500 gpio controllers. 
> 
> This is based off upstream/master with two of Cédric's patches:
> - aspeed: add a per SoC mapping for the interrupt space
> - aspeed: add a per SoC mapping for the memory space
> 
> 
> Any feedback would be great!


When you resend, could you please use the comment in aspeed_gpio.c 
as a commit log ? and add Peter in cc:

Thanks,

C. 


> Rashmica Gupta (2):
>   hw/gpio: Add basic Aspeed GPIO model
>   aspeed: add a GPIO controller to the SoC
> 
>  hw/arm/aspeed_soc.c           |  17 +
>  hw/gpio/Makefile.objs         |   1 +
>  hw/gpio/aspeed_gpio.c         | 869 ++++++++++++++++++++++++++++++++++
>  include/hw/arm/aspeed_soc.h   |   3 +
>  include/hw/gpio/aspeed_gpio.h |  76 +++
>  5 files changed, 966 insertions(+)
>  create mode 100644 hw/gpio/aspeed_gpio.c
>  create mode 100644 include/hw/gpio/aspeed_gpio.h
>