Re: [PATCH 11/13] hw: Move Aspeed RTC from hw/timer/ to hw/rtc/ subdirectory

[Philippe Mathieu-Daudé]

On 9/16/19 7:21 PM, Cédric Le Goater wrote:
> On 16/09/2019 17:48, Philippe Mathieu-Daudé wrote:
> > Move RTC devices under the hw/rtc/ subdirectory.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>
> I suppose the removal of the header files in "aspeed_rtc.h" is OK.

They are not used. It is probably cleaner to do this change in a 
separate patch.

> Reviewed-by: Cédric Le Goater <address@hidden>

Thanks!

[...]
> > diff --git a/include/hw/timer/aspeed_rtc.h b/include/hw/rtc/aspeed_rtc.h
> > similarity index 92%
> > rename from include/hw/timer/aspeed_rtc.h
> > rename to include/hw/rtc/aspeed_rtc.h
> > index 15ba42912b..156c8faee3 100644
> > --- a/include/hw/timer/aspeed_rtc.h
> > +++ b/include/hw/rtc/aspeed_rtc.h
> > @@ -8,9 +8,6 @@
> >   #ifndef ASPEED_RTC_H
> >   #define ASPEED_RTC_H
> >   
> > -#include <stdint.h>
> > -
> > -#include "hw/irq.h"
> >   #include "hw/sysbus.h"
> >   
> >   typedef struct AspeedRtcState {