Re: [PATCH v2 11/21] hw/timer/exynos4210_mct.c: Switch GFRC to transaction-based ptimer API

[Peter Maydell]

On Wed, 9 Oct 2019 at 02:58, Richard Henderson
<address@hidden> wrote:
>
> On 10/8/19 9:56 PM, Richard Henderson wrote:
> > On 10/8/19 1:17 PM, Peter Maydell wrote:
> >> @@ -945,7 +977,7 @@ static void 
> >> exynos4210_mct_update_freq(Exynos4210MCTState *s)
> >>          DPRINTF("freq=%dHz\n", s->freq);
> >>
> >>          /* global timer */
> >> -        ptimer_set_freq(s->g_timer.ptimer_frc, s->freq);
> >> +        tx_ptimer_set_freq(s->g_timer.ptimer_frc, s->freq);
> >>
> >>          /* local timer */
> >>          ptimer_set_freq(s->l_timer[0].tick_timer.ptimer_tick, s->freq);
> >
> > Failed to update them all, it would appear.
>
> Ho hum.  Done in a subsequent patch.
> I didn't realize that you weren't converting the entire file at once.

Yeah, the MCT device is pretty complicated and (per the commit
message) I felt it was easier to write and debug by switching
each ptimer one at a time rather than trying to do the whole
lot at the same time.

thanks
-- PMM