[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/21] hw/alpha/dp264: Create the RAM in the board
From: |
Richard Henderson |
Subject: |
Re: [PATCH 08/21] hw/alpha/dp264: Create the RAM in the board |
Date: |
Mon, 21 Oct 2019 10:27:24 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote:
> @@ -73,8 +74,16 @@ static void clipper_init(MachineState *machine)
> cpus[0]->env.trap_arg1 = 0;
> cpus[0]->env.trap_arg2 = smp_cpus;
>
> + /*
> + * Main memory region, 0x00.0000.0000. Real hardware supports 32GB,
> + * but the address space hole reserved at this point is 8TB.
> + */
> + memory_region_allocate_system_memory(&ram_region, NULL, "ram",
> + ram_size);
> + memory_region_add_subregion(get_system_memory(), 0, &ram_region);
The thing that I don't like about this is that ...
> @@ -849,12 +848,6 @@ PCIBus *typhoon_init(ram_addr_t ram_size, ISABus
> **isa_bus,
>
> *p_rtc_irq = qemu_allocate_irq(typhoon_set_timer_irq, s, 0);
>
> - /* Main memory region, 0x00.0000.0000. Real hardware supports 32GB,
> - but the address space hole reserved at this point is 8TB. */
> - memory_region_allocate_system_memory(&s->ram_region, NULL, "ram",
> - ram_size);
> - memory_region_add_subregion(addr_space, 0, &s->ram_region);
> -
> /* TIGbus, 0x801.0000.0000, 1GB. */
> /* ??? The TIGbus is used for delivering interrupts, and access to
> the flash ROM. I'm not sure that we need to implement it at all. */
... previously, it was clear that Typhoon owns the entire address space layout.
With this moved to dp264.c, the "address space hole" comment is out of context
and makes no sense.
Would it be too weird to pass in a MemoryRegion* to typhoon_init and leave the
memory_region_add_subregion() call where it is?
r~
- [PATCH 05/21] hw/arm/omap1: Create the RAM in the board, (continued)
- [PATCH 05/21] hw/arm/omap1: Create the RAM in the board, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 06/21] hw/arm/digic4: Inline digic4_board_setup_ram() function, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 07/21] hw: Drop QOM ownership on memory_region_allocate_system_memory() calls, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 08/21] hw/alpha/dp264: Create the RAM in the board, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 09/21] hw: Let memory_region_allocate_system_memory take MachineState argument, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 10/21] hw/core: Let the machine be the owner of the system memory, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 11/21] hw/alpha: Let the machine be the owner of the system memory, Philippe Mathieu-Daudé, 2019/10/20