[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 00/22] target/arm: Reduce overhead of cpu_get_tb_cpu_state
From: |
Peter Maydell |
Subject: |
Re: [PATCH v8 00/22] target/arm: Reduce overhead of cpu_get_tb_cpu_state |
Date: |
Tue, 22 Oct 2019 13:47:22 +0100 |
On Fri, 18 Oct 2019 at 18:44, Richard Henderson
<address@hidden> wrote:
>
> Changes since v7:
> * Rebuild hflags for all successful nvic writes (Peter).
> * Rebuild hflags for Xscale sctlr writes (Peter).
>
> Changes since v6:
> * Regen hflags in two more places for m-profile (patch 19).
>
> Changes since v5:
> * Fix the debug assertion ifdef in the final patch.
> * Add more calls to arm_rebuild_hflags: CPSR and M-profile
> These become two new patches, 18 & 19.
> * Update some comments per review. (Alex)
>
> Changes since v4:
> * Split patch 1 into 15 smaller patches.
> * Cache the new DEBUG_TARGET_EL field.
> * Split out m-profile hflags separately from a-profile 32-bit.
> * Move around non-cached tb flags as well, avoiding repetitive
> checks for m-profile or other mutually exclusive conditions.
>
> I haven't officially re-run the performance test quoted in the
> last patch, but I have eyeballed "perf top", and have dug into
> the compiled code a bit, which resulted in a few of the new
> cleanup patches (e.g. cs_base, arm_mmu_idx_el, and
> arm_cpu_data_is_big_endian).
> ...
>
>
> r~
Applied to target-arm.next, thanks.
-- PMM
- [PATCH v8 11/22] target/arm: Hoist computation of TBFLAG_A32.VFPEN, (continued)
- [PATCH v8 11/22] target/arm: Hoist computation of TBFLAG_A32.VFPEN, Richard Henderson, 2019/10/18
- [PATCH v8 12/22] target/arm: Add arm_rebuild_hflags, Richard Henderson, 2019/10/18
- [PATCH v8 13/22] target/arm: Split out arm_mmu_idx_el, Richard Henderson, 2019/10/18
- [PATCH v8 17/22] target/arm: Rebuild hflags at MSR writes, Richard Henderson, 2019/10/18
- [PATCH v8 18/22] target/arm: Rebuild hflags at CPSR writes, Richard Henderson, 2019/10/18
- [PATCH v8 16/22] target/arm: Rebuild hflags at EL changes, Richard Henderson, 2019/10/18
- [PATCH v8 19/22] target/arm: Rebuild hflags at Xscale SCTLR writes, Richard Henderson, 2019/10/18
- [PATCH v8 20/22] target/arm: Rebuild hflags for M-profile, Richard Henderson, 2019/10/18
- [PATCH v8 21/22] target/arm: Rebuild hflags for M-profile NVIC, Richard Henderson, 2019/10/18
- [PATCH v8 22/22] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state, Richard Henderson, 2019/10/18
- Re: [PATCH v8 00/22] target/arm: Reduce overhead of cpu_get_tb_cpu_state,
Peter Maydell <=