[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 08/33] serial: add "chardev" property
From: |
Marc-André Lureau |
Subject: |
[PATCH v3 08/33] serial: add "chardev" property |
Date: |
Wed, 23 Oct 2019 19:31:29 +0200 |
This is more QOM-friendly, callers may set/get the property themself.
Signed-off-by: Marc-André Lureau <address@hidden>
---
hw/char/serial.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/hw/char/serial.c b/hw/char/serial.c
index 4af8b0ce4c..09e89727a6 100644
--- a/hw/char/serial.c
+++ b/hw/char/serial.c
@@ -34,6 +34,7 @@
#include "sysemu/runstate.h"
#include "qemu/error-report.h"
#include "trace.h"
+#include "hw/qdev-properties.h"
//#define DEBUG_SERIAL
@@ -988,7 +989,7 @@ SerialState *serial_init(int base, qemu_irq irq, int
baudbase,
s->irq = irq;
s->baudbase = baudbase;
- qemu_chr_fe_init(&s->chr, chr, &error_abort);
+ qdev_prop_set_chr(dev, "chardev", chr);
serial_realize_core(s, &error_fatal);
qdev_set_legacy_instance_id(dev, base, 2);
qdev_init_nofail(dev);
@@ -999,11 +1000,17 @@ SerialState *serial_init(int base, qemu_irq irq, int
baudbase,
return s;
}
+static Property serial_properties[] = {
+ DEFINE_PROP_CHR("chardev", SerialState, chr),
+ DEFINE_PROP_END_OF_LIST(),
+};
+
static void serial_class_init(ObjectClass *klass, void* data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
dc->vmsd = &vmstate_serial;
+ dc->props = serial_properties;
}
static const TypeInfo serial_info = {
@@ -1064,7 +1071,7 @@ SerialState *serial_mm_init(MemoryRegion *address_space,
s->it_shift = it_shift;
s->irq = irq;
s->baudbase = baudbase;
- qemu_chr_fe_init(&s->chr, chr, &error_abort);
+ qdev_prop_set_chr(dev, "chardev", chr);
serial_realize_core(s, &error_fatal);
qdev_set_legacy_instance_id(dev, base, 2);
--
2.23.0.606.g08da6496b6
- [PATCH v3 01/33] qdev: remove unused qdev_prop_int64, (continued)
- [PATCH v3 01/33] qdev: remove unused qdev_prop_int64, Marc-André Lureau, 2019/10/23
- [PATCH v3 02/33] sysbus: remove unused sysbus_try_create*, Marc-André Lureau, 2019/10/23
- [PATCH v3 03/33] sysbus: remove outdated comment, Marc-André Lureau, 2019/10/23
- [PATCH v3 04/33] chardev: generate an internal id when none given, Marc-André Lureau, 2019/10/23
- [PATCH v3 05/33] serial-pci-multi: factor out multi_serial_get_nr_ports, Marc-André Lureau, 2019/10/23
- [PATCH v3 06/33] serial: initial qom-ification, Marc-André Lureau, 2019/10/23
- [PATCH v3 07/33] serial: register vmsd with DeviceClass, Marc-André Lureau, 2019/10/23
- [PATCH v3 08/33] serial: add "chardev" property,
Marc-André Lureau <=
- [PATCH v3 09/33] serial: add "baudbase" property, Marc-André Lureau, 2019/10/23
- [PATCH v3 10/33] serial: add "instance-id" property, Marc-André Lureau, 2019/10/23
- [PATCH v3 11/33] serial: realize the serial device, Marc-André Lureau, 2019/10/23
- [PATCH v3 13/33] serial: start making SerialMM a sysbus device, Marc-André Lureau, 2019/10/23
- [PATCH v3 12/33] serial: replace serial_exit_core() with unrealize, Marc-André Lureau, 2019/10/23
- [PATCH v3 14/33] serial-mm: add "regshift" property, Marc-André Lureau, 2019/10/23
- [PATCH v3 16/33] serial-mm: use sysbus facilities, Marc-André Lureau, 2019/10/23
- [PATCH v3 15/33] serial-mm: add endianness property, Marc-André Lureau, 2019/10/23