Re: [RFC PATCH 19/27] target/arm: Move common cpregs code into a separate file

[Richard Henderson]

On 1/4/23 13:58, Fabiano Rosas wrote:
> Code moved verbatim.
>
> Signed-off-by: Fabiano Rosas<farosas@suse.de>
> ---
> Extracted from:
> https://lore.kernel.org/r/20210416162824.25131-15-cfontana@suse.de
> [RFC v14 14/80] target/arm: split cpregs from tcg/helper.c
> ---
>   target/arm/cpregs.c    | 482 +++++++++++++++++++++++++++++++++++++++++
>   target/arm/helper.c    | 472 ----------------------------------------
>   target/arm/meson.build |   1 +
>   3 files changed, 483 insertions(+), 472 deletions(-)
>   create mode 100644 target/arm/cpregs.c

Ok, now I'd like to know what the intended difference between cpregs.c and 
cpustate-list.c.  If it were only write_cpustate_to_list and write_list_to_cpustate in the 
latter file, that might be one thing.  But get_arm_cp_reginfo definitely belongs in cpregs.c.


r~