[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 01/12] aspeed/hace: Initialize g_autofree pointer
From: |
Cédric Le Goater |
Subject: |
[PATCH 01/12] aspeed/hace: Initialize g_autofree pointer |
Date: |
Mon, 8 May 2023 09:58:48 +0200 |
As mentioned in docs/devel/style.rst "Automatic memory deallocation":
* Variables declared with g_auto* MUST always be initialized,
otherwise the cleanup function will use uninitialized stack memory
This avoids QEMU to coredump when running the "hash test" command
under Zephyr.
Cc: Steven Lee <steven_lee@aspeedtech.com>
Cc: Joel Stanley <joel@jms.id.au>
Fixes: c5475b3f9a ("hw: Model ASPEED's Hash and Crypto Engine")
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20230421131547.2177449-1-clg@kaod.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/misc/aspeed_hace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c
index 12a761f1f5..b07506ec04 100644
--- a/hw/misc/aspeed_hace.c
+++ b/hw/misc/aspeed_hace.c
@@ -189,7 +189,7 @@ static void do_hash_operation(AspeedHACEState *s, int algo,
bool sg_mode,
bool acc_mode)
{
struct iovec iov[ASPEED_HACE_MAX_SG];
- g_autofree uint8_t *digest_buf;
+ g_autofree uint8_t *digest_buf = NULL;
size_t digest_len = 0;
int niov = 0;
int i;
--
2.40.0
- [PATCH 00/12] aspeed: fixes and extensions, Cédric Le Goater, 2023/05/08
- [PATCH 02/12] aspeed: Introduce a boot_rom region at the machine level, Cédric Le Goater, 2023/05/08
- [PATCH 03/12] aspeed: Use the boot_rom region of the fby35 machine, Cédric Le Goater, 2023/05/08
- [PATCH 04/12] hw/ssi: Add an "addr" property to SSIPeripheral, Cédric Le Goater, 2023/05/08
- [PATCH 01/12] aspeed/hace: Initialize g_autofree pointer,
Cédric Le Goater <=
- [PATCH 05/12] hw/ssi: Introduce a ssi_get_cs() helper, Cédric Le Goater, 2023/05/08
- Re: [PATCH 05/12] hw/ssi: Introduce a ssi_get_cs() helper, Philippe Mathieu-Daudé, 2023/05/30
- Re: [PATCH 05/12] hw/ssi: Introduce a ssi_get_cs() helper, Philippe Mathieu-Daudé, 2023/05/30
- Re: [PATCH 05/12] hw/ssi: Introduce a ssi_get_cs() helper, Cédric Le Goater, 2023/05/31
- Re: [PATCH 05/12] hw/ssi: Introduce a ssi_get_cs() helper, Philippe Mathieu-Daudé, 2023/05/31
- Re: [PATCH 05/12] hw/ssi: Introduce a ssi_get_cs() helper, Cédric Le Goater, 2023/05/31
- Re: [PATCH 05/12] hw/ssi: Introduce a ssi_get_cs() helper, Philippe Mathieu-Daudé, 2023/05/31
- Re: [PATCH 05/12] hw/ssi: Introduce a ssi_get_cs() helper, Cédric Le Goater, 2023/05/31