Re: [PATCH v2 1/1] Add vpd data for Rainier machine

[Ninad Palsule]

Hello Philippe,

On 5/23/23 3:52 AM, Philippe Mathieu-Daudé wrote:
> Hi Ninad,
>
> On 22/5/23 17:36, Ninad Palsule wrote:
> > The VPD data is added for system and BMC FRU. This data is fabricated.
>
> Per 
> https://www.qemu.org/docs/master/devel/submitting-a-patch.html#write-a-meaningful-commit-message:
>
>   QEMU follows the usual standard for git commit messages: the first
>   line (which becomes the email subject line) is “subsystem: single
>   line summary of change”.
>
> In this patch the subsystem is "hw/arm", but you can also use
> "hw/arm/aspeed" or even "hw/arm/aspeed_eeprom" for subject prefix.
Added subsystem tag.
> > Tested:
> >     - The system-vpd.service is active.
> >     - VPD service related to bmc is active.
>
>   ... more detailed description of the patch, another blank and your
>   Signed-off-by: line.
Added more details in the description.
> Missing a blank line :)

Added blank line.

Thank you for the review!

> > Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
> > ---
> >   hw/arm/aspeed.c        |  6 ++++--
> >   hw/arm/aspeed_eeprom.c | 45 +++++++++++++++++++++++++++++++++++++++++-
> >   hw/arm/aspeed_eeprom.h |  5 +++++
> >   3 files changed, 53 insertions(+), 3 deletions(-)