[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 01/16] tcg: Fix register move type in tcg_out_ld_helper_re
From: |
Peter Maydell |
Subject: |
Re: [PATCH v4 01/16] tcg: Fix register move type in tcg_out_ld_helper_ret |
Date: |
Tue, 30 May 2023 14:36:45 +0100 |
On Fri, 26 May 2023 at 01:25, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> The first move was incorrectly using TCG_TYPE_I32 while the second
> move was correctly using TCG_TYPE_REG. This prevents a 64-bit host
> from moving all 128-bits of the return value.
>
> Fixes: ebebea53ef8 ("tcg: Support TCG_TYPE_I128 in
> tcg_out_{ld,st}_helper_{args,ret}")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/tcg.c | 4 ++--
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v4 00/16] tcg: Improvements to atomic128, Richard Henderson, 2023/05/25
- [PATCH v4 02/16] accel/tcg: Fix check for page writeability in load_atomic16_or_exit, Richard Henderson, 2023/05/25
- Re: [PATCH v4 02/16] accel/tcg: Fix check for page writeability in load_atomic16_or_exit, Peter Maydell, 2023/05/30
- Re: [PATCH v4 02/16] accel/tcg: Fix check for page writeability in load_atomic16_or_exit, Richard Henderson, 2023/05/30
- Re: [PATCH v4 02/16] accel/tcg: Fix check for page writeability in load_atomic16_or_exit, Peter Maydell, 2023/05/30
- Re: [PATCH v4 02/16] accel/tcg: Fix check for page writeability in load_atomic16_or_exit, Richard Henderson, 2023/05/30
- Re: [PATCH v4 02/16] accel/tcg: Fix check for page writeability in load_atomic16_or_exit, Peter Maydell, 2023/05/30
- Re: [PATCH v4 02/16] accel/tcg: Fix check for page writeability in load_atomic16_or_exit, Richard Henderson, 2023/05/30
[PATCH v4 01/16] tcg: Fix register move type in tcg_out_ld_helper_ret, Richard Henderson, 2023/05/25
- Re: [PATCH v4 01/16] tcg: Fix register move type in tcg_out_ld_helper_ret,
Peter Maydell <=
[PATCH v4 03/16] meson: Split test for __int128_t type from __int128_t arithmetic, Richard Henderson, 2023/05/25
[PATCH v4 05/16] tcg/i386: Support 128-bit load/store, Richard Henderson, 2023/05/25
[PATCH v4 06/16] tcg/aarch64: Rename temporaries, Richard Henderson, 2023/05/25
[PATCH v4 04/16] qemu/atomic128: Add x86_64 atomic128-ldst.h, Richard Henderson, 2023/05/25
[PATCH v4 07/16] tcg/aarch64: Reserve TCG_REG_TMP1, TCG_REG_TMP2, Richard Henderson, 2023/05/25
[PATCH v4 08/16] tcg/aarch64: Simplify constraints on qemu_ld/st, Richard Henderson, 2023/05/25