[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 08/38] tests/qtests: clean-up and fix leak in generic_fuzz
From: |
Alex Bennée |
Subject: |
[PATCH v4 08/38] tests/qtests: clean-up and fix leak in generic_fuzz |
Date: |
Fri, 30 Jun 2023 19:03:53 +0100 |
An update to the clang tooling detects more issues with the code
including a memory leak from the g_string_new() allocation. Clean up
the code to avoid the allocation and use ARRAY_SIZE while we are at
it.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
v3
- use g_strconcat instead
---
tests/qtest/fuzz/generic_fuzz.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuzz.c
index c525d22951..11256abf6c 100644
--- a/tests/qtest/fuzz/generic_fuzz.c
+++ b/tests/qtest/fuzz/generic_fuzz.c
@@ -954,17 +954,10 @@ static void register_generic_fuzz_targets(void)
.crossover = generic_fuzz_crossover
});
- GString *name;
- const generic_fuzz_config *config;
-
- for (int i = 0;
- i < sizeof(predefined_configs) / sizeof(generic_fuzz_config);
- i++) {
- config = predefined_configs + i;
- name = g_string_new("generic-fuzz");
- g_string_append_printf(name, "-%s", config->name);
+ for (int i = 0; i < ARRAY_SIZE(predefined_configs); i++) {
+ const generic_fuzz_config *config = predefined_configs + i;
fuzz_add_target(&(FuzzTarget){
- .name = name->str,
+ .name = g_strconcat("generic-fuzz-", config->name, NULL),
.description = "Predefined generic-fuzz config.",
.get_init_cmdline = generic_fuzz_predefined_config_cmdline,
.pre_fuzz = generic_pre_fuzz,
--
2.39.2
- [PATCH v4 00/38] maintainer omnibus: testing, fuzz, plugins, documentation, gdbstub (pre-PR), Alex Bennée, 2023/06/30
- [PATCH v4 02/38] gitlab: ensure coverage job also publishes meson log, Alex Bennée, 2023/06/30
- [PATCH v4 03/38] gitlab: reduce testing scope of check-gcov, Alex Bennée, 2023/06/30
- [PATCH v4 10/38] Makefile: add lcitool-refresh to UNCHECKED_GOALS, Alex Bennée, 2023/06/30
- [PATCH v4 01/38] gitlab: explicit set artifacts publishing criteria, Alex Bennée, 2023/06/30
- [PATCH v4 04/38] docs/devel: remind developers to run CI container pipeline when updating images, Alex Bennée, 2023/06/30
- [PATCH v4 08/38] tests/qtests: clean-up and fix leak in generic_fuzz,
Alex Bennée <=
- [PATCH v4 09/38] tests/docker: add test-fuzz, Alex Bennée, 2023/06/30
- [PATCH v4 05/38] tests/tcg: add mechanism to handle plugin arguments, Alex Bennée, 2023/06/30
- [PATCH v4 06/38] qemu-keymap: properly check return from xkb_keymap_mod_get_index, Alex Bennée, 2023/06/30
- [PATCH v4 07/38] scripts/oss-fuzz: add a suppression for keymap, Alex Bennée, 2023/06/30
- [PATCH v4 12/38] tests/lcitool: Bump fedora container versions, Alex Bennée, 2023/06/30
- [PATCH v4 11/38] tests/lcitool: update to latest version, Alex Bennée, 2023/06/30
- [PATCH v4 38/38] tests/tcg: Add a test for info proc mappings, Alex Bennée, 2023/06/30
- [PATCH v4 14/38] tests/lcitool: introduce qemu-minimal, Alex Bennée, 2023/06/30
- [PATCH v4 13/38] tests/lcitool: add an explicit gcc-native package, Alex Bennée, 2023/06/30
- [PATCH v4 30/38] gdbstub: clean-up vcont handling to avoid goto, Alex Bennée, 2023/06/30