Re: [PATCH 3/3] tests/tcg: Add -fno-stack-protector

[Thomas Huth]

On 31/07/2023 08.58, Akihiko Odaki wrote:
> A build of GCC 13.2 will have stack protector enabled by default if it
> was configured with --enable-default-ssp option. For such a compiler,
> it is necessary to explicitly disable stack protector when linking
> without standard libraries.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>   tests/tcg/mips/hello-mips.c                   | 4 ++--
>   tests/tcg/aarch64/Makefile.softmmu-target     | 2 +-
>   tests/tcg/aarch64/Makefile.target             | 2 +-
>   tests/tcg/alpha/Makefile.softmmu-target       | 2 +-
>   tests/tcg/arm/Makefile.target                 | 2 +-
>   tests/tcg/cris/Makefile.target                | 2 +-
>   tests/tcg/hexagon/Makefile.target             | 2 +-
>   tests/tcg/i386/Makefile.softmmu-target        | 2 +-
>   tests/tcg/i386/Makefile.target                | 2 +-
>   tests/tcg/loongarch64/Makefile.softmmu-target | 2 +-
>   tests/tcg/minilib/Makefile.target             | 2 +-
>   tests/tcg/mips/Makefile.target                | 2 +-
>   tests/tcg/nios2/Makefile.softmmu-target       | 2 +-
>   tests/tcg/s390x/Makefile.softmmu-target       | 2 +-
>   tests/tcg/x86_64/Makefile.softmmu-target      | 2 +-
>   15 files changed, 16 insertions(+), 16 deletions(-)

I think the changes to the Makefile.softmmu-target files should rather be 
done in a central place, in tests/tcg/Makefile.target, right after the 
"EXTRA_CFLAGS += -ffreestanding" there.

 Thomas