qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/10] tests/virtio-scsi: Clean up global variable shadowing


From: Thomas Huth
Subject: Re: [PATCH 03/10] tests/virtio-scsi: Clean up global variable shadowing
Date: Fri, 13 Oct 2023 07:57:28 +0200
User-agent: Mozilla Thunderbird

On 09/10/2023 12.02, Philippe Mathieu-Daudé wrote:
Rename the (unused) 'allow' argument, following the pattern
used by the other tests in this file. This fixes:

   tests/qtest/virtio-scsi-test.c:159:61: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static void hotplug(void *obj, void *data, QGuestAllocator *alloc)
                                                               ^
   tests/qtest/virtio-scsi-test.c:37:25: note: previous declaration is here
   static QGuestAllocator *alloc;
                           ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
  tests/qtest/virtio-scsi-test.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/virtio-scsi-test.c b/tests/qtest/virtio-scsi-test.c
index ceaa7f2415..db10d572d0 100644
--- a/tests/qtest/virtio-scsi-test.c
+++ b/tests/qtest/virtio-scsi-test.c
@@ -156,7 +156,7 @@ static QVirtioSCSIQueues *qvirtio_scsi_init(QVirtioDevice 
*dev)
      return vs;
  }
-static void hotplug(void *obj, void *data, QGuestAllocator *alloc)
+static void hotplug(void *obj, void *data, QGuestAllocator *t_alloc)
  {
      QTestState *qts = global_qtest;

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]