qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/timer/npcm7xx_timer: Prevent timer from counting down pas


From: Peter Maydell
Subject: Re: [PATCH] hw/timer/npcm7xx_timer: Prevent timer from counting down past zero
Date: Tue, 17 Oct 2023 14:18:38 +0100

On Fri, 22 Sept 2023 at 19:14, Chris Rauer <crauer@google.com> wrote:
>
> The counter register is only 24-bits and counts down.  If the timer is
> running but the qtimer to reset it hasn't fired off yet, there is a chance
> the regster read can return an invalid result.
>
> Signed-off-by: Chris Rauer <crauer@google.com>

Applied to target-arm.next, thanks.

(As a side note, if you'd used the ptimer countdown-timer functions
to implement this timer, this is one of the corner cases that it
would have got right for you ;-))

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]