Re: [PATCH 12/12] hw/sysbus: Ensure device is realized before mapping it

[Philippe Mathieu-Daudé]

On 18/10/23 18:13, Thomas Huth wrote:
> On 18/10/2023 16.11, Philippe Mathieu-Daudé wrote:
> > sysbus_mmio_map() should not be called on unrealized device.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   hw/core/sysbus.c | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c
> > index ce54e2c416..a46828a808 100644
> > --- a/hw/core/sysbus.c
> > +++ b/hw/core/sysbus.c
> > @@ -20,6 +20,7 @@
> >   #include "qemu/osdep.h"
> >   #include "qapi/error.h"
> >   #include "qemu/module.h"
> > +#include "qemu/error-report.h"
>
> I assume this hunk should go into the previous patch?

Oops indeed...


> With the hunk moved (or the order of the patches reversed):
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>

Thanks!