Re: [PATCH v2 2/4] hw/char/stm32f2xx_usart: Update IRQ when SR is read

[Hans-Erik Floryd]

On Mon, 23 Oct 2023 at 03:37, Alistair Francis <alistair23@gmail.com> wrote:
>
> On Sat, Oct 21, 2023 at 4:12 AM Philippe Mathieu-Daudé
> <philmd@linaro.org> wrote:
> >
> > From: Hans-Erik Floryd <hans-erik.floryd@rt-labs.com>
> >
> > Signed-off-by: Hans-Erik Floryd <hans-erik.floryd@rt-labs.com>
> > [PMD: Split from bigger patch]
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> > Is this required?
>
> I don't think this is required
>
> Alistair

I agree this should be removed. It was added because the manual says
that some irq:s are cleared by a combination of reading SR and writing
to DR. However, those bits are not implemented yet, and probably the
clearing should be done when writing DR anyway.

Thanks for reviewing,
 Hans-Erik