Re: [PATCH v3] fsl-imx: add simple RTC emulation for i.MX6 and i.MX7 boards

[Nikita Ostrenkov]

Sorry again. Honestly, I was in a hurry.

Unfortunately, I'm currently using a different PC, and git publish doesn't work on it (some issues with SSL certificates). I sent the first and second versions of the patch from my main home PC through this way, but, regrettably, I had to manually send the third version via the Gmail web client.

You're right. I tested the patch on qemu v8.1.3. However, I made the changes on the master branch.

Tomorrow, I will definitely test the patch on the master branch and try to resolve the issues with git publish. I'll send the fourth version of the patch.

Thanks!

чт, 14 дек. 2023 г., 20:23 Peter Maydell <peter.maydell@linaro.org>:

On Thu, 14 Dec 2023 at 11:49, Nikita Ostrenkov <n.ostrenkov@gmail.com> wrote:
>
> Signed-off-by: Nikita Ostrenkov <n.ostrenkov@gmail.com>
> ---
>  hw/misc/imx7_snvs.c         | 91 ++++++++++++++++++++++++++++++++++---
>  hw/misc/trace-events        |  4 +-
>  include/hw/misc/imx7_snvs.h |  7 ++-
>  3 files changed, 92 insertions(+), 10 deletions(-)

Hi; this doesn't compile for me:
../../hw/misc/imx7_snvs.c:139:5: error: implicit declaration of
function 'qemu_get_timedate' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
    qemu_get_timedate(&tm, 0);
    ^
../../hw/misc/imx7_snvs.c:140:22: error: implicit declaration of
function 'mktimegm' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
    s->tick_offset = mktimegm(&tm) -
                     ^

How have you been testing it? This looks like a missing
include line, so I'm wondering if you've been testing it
against an older version of QEMU rather than the current
head-of-git? (If I fix that error then there's another
one after it because the include line to get mktimegm() is
missing too.)

Also, your email client has unfortunately mangled the patch in
a couple of ways:
 * it's sent it as combined HTML/text, not as plain text only
 * it has wrapped some long lines
 * it has sent it base64 encoded

If you're planning to submit more QEMU patches in future,
it would be worth looking at the notes in
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#submitting-your-patches
about 'git send-email'. For a single patch, I can fix stuff
up by hand at this end, but it's a bit awkward.

Other than that, the patch looks good to me.

thanks
-- PMM