Re: [PATCH v2 3/3] tests/qtest: Add testcase for BCM2835 BSC

[Rayhan Faizel]

Hi Thomas,

Do you want me to add an SPDX line to the other two commits or will just this one suffice?

On Tue, Feb 20, 2024 at 9:45 AM Thomas Huth <thuth@redhat.com> wrote:

On 19/02/2024 23.59, Rayhan Faizel wrote:
> Simple testcase for validating proper operation of read and write for all
> three BSC controllers.
>
> Signed-off-by: Rayhan Faizel <rayhan.faizel@gmail.com>
> ---
>   tests/qtest/bcm2835-i2c-test.c | 105 +++++++++++++++++++++++++++++++++
>   tests/qtest/meson.build        |   2 +-
>   2 files changed, 106 insertions(+), 1 deletion(-)
>   create mode 100644 tests/qtest/bcm2835-i2c-test.c
>
> diff --git a/tests/qtest/bcm2835-i2c-test.c b/tests/qtest/bcm2835-i2c-test.c
> new file mode 100644
> index 0000000000..6ec15b8976
> --- /dev/null
> +++ b/tests/qtest/bcm2835-i2c-test.c
> @@ -0,0 +1,105 @@
> +/*
> + * QTest testcase for Broadcom Serial Controller (BSC)
> + *
> + * Copyright (c) 2024 Rayhan Faizel <rayhan.faizel@gmail.com>
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a copy
> + * of this software and associated documentation files (the "Software"), to deal
> + * in the Software without restriction, including without limitation the rights
> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> + * copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
> + * THE SOFTWARE.
> + */

Could you maybe also add a SPDX license line, so that it is more obvious at
a quick glance what license this is?

Anyway,
Acked-by: Thomas Huth <thuth@redhat.com>

--

Rayhan Faizel