Re: [PATCH v6 2/6] pc-bios: Add AST27x0 vBootrom

[Cédric Le Goater]

On 4/25/25 04:28, Jamin Lin wrote:
> Hi Cedric, Nabih
>
> > Subject: Re: [PATCH v6 2/6] pc-bios: Add AST27x0 vBootrom
> >
> > On 4/24/25 09:51, Jamin Lin wrote:
> > > The boot ROM is a minimal implementation designed to load an AST27x0
> > boot image.
> > > Its source code is available at:
> > > https://github.com/google/vbootrom
> > > Commit id: 82bed5ca62295228ea7bcdc721b63db178f686e8
> >
> > It would be good to report some build info when vbootrom starts.
> >
> > Today we have,
> >
> >      _    ______  ____  ____  __________  ____  __  ___      ___
> > ______________  ______  ______
> >     | |  / / __ )/ __ \/ __ \/_  __/ __ \/ __ \/  |/  /     /   | / ___/_
> > __/__ \/__  / |/ / __ \
> >     | | / / __  / / / / / / / / / / /_/ / / / / /|_/ /_____/ /| | \__ \ / /  
> > __/ /  /
> > /|   / / / /
> >     | |/ / /_/ / /_/ / /_/ / / / / _, _/ /_/ / /  / /_____/ ___ |___/ // /  / 
> > __/  /
> > //   / /_/ /
> >     |___/_____/\____/\____/ /_/ /_/ |_|\____/_/  /_/     /_/
> > |_/____//_/  /____/ /_//_/|_\____/
> >
> >     Version:1.0.0
> >
> > I don't see any 1.0.0 tag under https://github.com/google/vbootrom ?
> >
> > Other firmware images report :
> >
> >     Jumping to BL31 (Trusted Firmware-A) at 0x430000000
> >
> >     NOTICE:  BL31: v2.10.3(release):lts-v2.10.3-dirty
> >     NOTICE:  BL31: Built : 17:17:34, Apr  5 2024
> >     I/TC:
> >     I/TC: OP-TEE version: 4.1.0-dev (gcc version 13.2.0 (GCC)) #1 Fri Jan 19
> > 17:14:14 UTC 2024 aarch64
> >     I/TC: WARNING: This OP-TEE configuration might be insecure!
> >     I/TC: WARNING: Please check
> > https://optee.readthedocs.io/en/latest/architecture/porting_guidelines.html
> >     I/TC: Primary CPU initializing
> >     I/TC: Primary CPU switching to normal world boot
> >
> >     U-Boot 2023.10-v00.05.06 (Mar 26 2025 - 05:59:26 +0000)
> >
> >
> > OpenFirmware:
> >
> >     SLOF
> > ****************************************************************
> > ******
> >     QEMU Starting
> >      Build Date = Nov  6 2024 15:31:54
> >      FW Version = git-ee03aec2c106a699
> >
> > OpenBIOS:
> >
> >     >>
> > =============================================================
> >     >> OpenBIOS 1.1 [Sep 24 2024 19:56]
> >     >> Configuration device id QEMU version 1 machine id 1
> >
> > SeaBIOS:
> >
> >     SeaBIOS (version rel-1.16.3-0-ga6ed6b701f0a-prebuilt.qemu.org)
> >
> > Adding a commit id, tag, build date to identify the firmware image would be
> > useful when issues are reported.
> >
> > See https://github.com/google/vbootrom/issues/6.
> >
> > > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> > > Reviewed-by: Nabih Estefan <nabihestefan@google.com>
> > > Tested-by: Nabih Estefan <nabihestefan@google.com>
> Thanks for review and suggestion.
>
> I submitted a pull request to fix this issue, please see
> https://github.com/google/vbootrom/pull/7
> https://github.com/google/vbootrom/issues/6

Approved.
 
> If you agree this build info format, I will resend this patch after this pull 
> request is merged.

Yes. Just resend this patch, I will insert it in the v6 series.

Thanks,

C.