[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED |
|
Date: |
Thu, 9 Apr 2015 09:30:06 +0200 |
|
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Wed, Apr 08, 2015 at 05:32:47PM -0600, Eric Blake wrote:
> > +- "device": Device name (json-string)
> > +- "node-name": Node name (json-string, optional)
> > +- "msg": Informative message (e.g., reason for the corruption)
> > + (json-string)
> > +- "offset": If the corruption resulted from an image access, this
> > + is the access offset into the image (json-int)
> > +- "size": If the corruption resulted from an image access, this
> > + is the access size (json-int)
>
> Not your fault (so don't worry about fixing it here), but I still
> find this definition of 'offset' confusing - is it the guest's
> offset, or the host's offset?
From the code it looks like it's the host's offset. And now that it
look into it both 'offset' and 'size' should be marked as optional
there (they are in block-core.json). I'll send a separate patch
correcting all those.
Berto