[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH for-2.4 V2 9/9] block/iscsi: use the allocationmap a
From: |
Peter Lieven |
Subject: |
[Qemu-block] [PATCH for-2.4 V2 9/9] block/iscsi: use the allocationmap also if cache.direct=on |
Date: |
Thu, 16 Apr 2015 16:08:33 +0200 |
the allocationmap has only a hint character. The driver always
double checks that blocks marked unallocated in the cache are
still unallocated before taking the fast path and return zeroes.
So using the allocationmap is migration safe and can
also be enabled with cache.direct=on.
Signed-off-by: Peter Lieven <address@hidden>
---
block/iscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 8364f97..8fca1d3 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1499,7 +1499,7 @@ static int iscsi_open(BlockDriverState *bs, QDict
*options, int flags,
iscsilun->bl.opt_unmap_gran * iscsilun->block_size <= 16 * 1024 *
1024) {
iscsilun->cluster_sectors = (iscsilun->bl.opt_unmap_gran *
iscsilun->block_size) >> BDRV_SECTOR_BITS;
- if (iscsilun->lbprz && !(bs->open_flags & BDRV_O_NOCACHE)) {
+ if (iscsilun->lbprz) {
iscsilun->allocationmap = iscsi_allocationmap_init(iscsilun);
if (iscsilun->allocationmap == NULL) {
ret = -ENOMEM;
--
1.9.1
- [Qemu-block] [PATCH for-2.4 V2 0/9] various improvements for the iSCSI driver, Peter Lieven, 2015/04/16
- [Qemu-block] [PATCH for-2.4 V2 4/9] block/iscsi: store DPOFUA bit from the modesense command, Peter Lieven, 2015/04/16
- [Qemu-block] [PATCH for-2.4 V2 3/9] block/iscsi: rename iscsi_write_protected and let it return void, Peter Lieven, 2015/04/16
- [Qemu-block] [PATCH for-2.4 V2 2/9] block/iscsi: change all iscsilun properties from uint8_t to bool, Peter Lieven, 2015/04/16
- [Qemu-block] [PATCH for-2.4 V2 1/9] block/iscsi: do not forget to logout from target, Peter Lieven, 2015/04/16
- [Qemu-block] [PATCH for-2.4 V2 9/9] block/iscsi: use the allocationmap also if cache.direct=on,
Peter Lieven <=
- [Qemu-block] [PATCH for-2.4 V2 8/9] block/iscsi: bump year in copyright notice, Peter Lieven, 2015/04/16
- [Qemu-block] [PATCH for-2.4 V2 5/9] block/iscsi: optimize WRITE10/16 if cache.writeback is not set, Peter Lieven, 2015/04/16
- [Qemu-block] [PATCH for-2.4 V2 7/9] block/iscsi: handle SCSI_STATUS_TASK_SET_FULL, Peter Lieven, 2015/04/16
- [Qemu-block] [PATCH for-2.4 V2 6/9] block/iscsi: increase retry count, Peter Lieven, 2015/04/16
- Re: [Qemu-block] [PATCH for-2.4 V2 0/9] various improvements for the iSCSI driver, Stefan Hajnoczi, 2015/04/23