[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-2.4 05/10] block/iscsi: optimize WRITE10/16
|
From: |
Peter Lieven |
|
Subject: |
Re: [Qemu-block] [PATCH for-2.4 05/10] block/iscsi: optimize WRITE10/16 if cache.writeback is not set |
|
Date: |
Fri, 17 Apr 2015 09:14:58 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
Am 16.04.2015 um 15:17 schrieb Paolo Bonzini:
>
> On 16/04/2015 15:02, Peter Lieven wrote:
>>> Also, I think it is iscsi_co_generic_cb that should set
>>> force_next_flush, so that it is only set on failure. Not really for the
>>> optimization value, but because it's clearer.
>> I don't get what you mean with it should only "set on failure".
>> My approach would be to add a flag to the iTask that the command
>> requires to set force_flush after successful completion. Is it that
>> what you mean?
> Set on success. Lack of sleep.
I have send a v2 following your suggestions.
Peter
- Re: [Qemu-block] [PATCH for-2.4 07/10] block/iscsi: bump libiscsi requirement to 1.10.0, (continued)
[Qemu-block] [PATCH for-2.4 06/10] block/iscsi: increase retry count, Peter Lieven, 2015/04/16
[Qemu-block] [PATCH for-2.4 08/10] block/iscsi: handle SCSI_STATUS_TASK_SET_FULL, Peter Lieven, 2015/04/16
[Qemu-block] [PATCH for-2.4 09/10] block/iscsi: bump year in copyright notice, Peter Lieven, 2015/04/16
[Qemu-block] [PATCH for-2.4 05/10] block/iscsi: optimize WRITE10/16 if cache.writeback is not set, Peter Lieven, 2015/04/16
[Qemu-block] [PATCH for-2.4 10/10] block/iscsi: use the allocationmap also if cache.direct=on, Peter Lieven, 2015/04/16
Re: [Qemu-block] [PATCH for-2.4 00/10] various improvements for the iSCSI driver, Paolo Bonzini, 2015/04/16