qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 03/11] block: rename BlkTransactionState and


From: Max Reitz
Subject: Re: [Qemu-block] [PATCH v2 03/11] block: rename BlkTransactionState and BdrvActionOps
Date: Fri, 17 Apr 2015 16:51:36 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 27.03.2015 20:19, John Snow wrote:
These structures are misnomers, somewhat.

(1) BlockTransactionState is not state for a transaction,
     but is rather state for a single transaction action.
     Rename it "BlkActionState" to be more accurate.

(2) The BdrvActionOps describes operations for the BlkActionState,
     above. This name might imply a 'BdrvAction' or a 'BdrvActionState',
     which there isn't.
     Rename this to 'BlkActionOps' to match 'BlkActionState'.

Lastly, update the surrounding in-line documentation and comments
to reflect the current nature of how Transactions operate.

This patch changes only comments and names, and should not affect
behavior in any way.

Signed-off-by: John Snow <address@hidden>
---
  blockdev.c | 114 ++++++++++++++++++++++++++++++++++---------------------------
  1 file changed, 64 insertions(+), 50 deletions(-)

Reviewed-by: Max Reitz <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]