[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 01/21] docs: incremental backup documentation
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v5 01/21] docs: incremental backup documentation |
Date: |
Fri, 17 Apr 2015 09:06:06 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/08/2015 04:19 PM, John Snow wrote:
> Reviewed-by: Max Reitz <address@hidden>
> Signed-off-by: John Snow <address@hidden>
> ---
> docs/bitmaps.md | 311
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 311 insertions(+)
> create mode 100644 docs/bitmaps.md
>
> diff --git a/docs/bitmaps.md b/docs/bitmaps.md
> new file mode 100644
> index 0000000..ad8c33b
> --- /dev/null
> +++ b/docs/bitmaps.md
> @@ -0,0 +1,311 @@
> +# Dirty Bitmaps and Incremental Backup
> +
Still might be nice to list explicit copyright/license instead of
relying on implicit top-level GPLv2+, but I won't insist.
> +### Deletion
> +
> +* Can be performed on a disabled bitmap, but not a frozen one.
Do you still have a notion of disabled bitmaps? Earlier, in '## Bitmap
Modes', you only document 'frozen' (as opposed to the default unnamed
state).
> +
> +## Transactions (Not yet implemented)
I'm assuming that "[PATCH v2 00/11] block: incremental backup
transactions" is incomplete, because it forgot to clean this up as part
of adding transaction support.
> +
> +5. Retry the command after fixing the underlaying problem,
s/underlaying/underlying/
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v5 00/21] block: transactionless incremental backup series, John Snow, 2015/04/08
- [Qemu-block] [PATCH v5 03/21] qmp: Ensure consistent granularity type, John Snow, 2015/04/08
- [Qemu-block] [PATCH v5 05/21] block: Introduce bdrv_dirty_bitmap_granularity(), John Snow, 2015/04/08
- [Qemu-block] [PATCH v5 06/21] hbitmap: cache array lengths, John Snow, 2015/04/08
- [Qemu-block] [PATCH v5 04/21] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove, John Snow, 2015/04/08
- [Qemu-block] [PATCH v5 07/21] hbitmap: add hbitmap_merge, John Snow, 2015/04/08