Re: [Qemu-block] [PATCH 2/8] block: allow block jobs in any arbitrary node

[Alberto Garcia]

On Wed 22 Apr 2015 10:06:15 PM CEST, Eric Blake wrote:

>> -- "device":   Device name (json-string)
>> +- "device":   Device name, or node name if not present (json-string)
>
> You used this wording for all the events...

>>  # Throttling can be disabled by setting the speed to 0.
>>  #
>> -# @device: the device name
>> +# @device: the device or node name of the owner of the block job.
>
> but this wording is different.  I like it a bit better ("node name if
> not present" feels like it could be a bit ambiguous as to what is not
> present, and "device or node name" is shorter than "device name, or
> node name if not present").

There's a reason for that.

I used "Device name, or node name if not present" in return types,
meaning that the field will always contain the device name first, and
fall back to the node name only if the device name is not present. I
think we should guarantee that the device name has precedence for
compatibility reasons, and I want to make that explicit in the
documentation.

I used "the device or node name of..." in command parameters, meaning
that both are accepted and equally valid, and that the user can choose
which one to pass.

Berto