|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description |
Date: | Thu, 23 Apr 2015 14:23:53 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 23/04/2015 14:19, Dr. David Alan Gilbert wrote: >> > So that means the bdrv_start_replication and bdrv_stop_replication >> > callbacks are more or less redundant, at least on the primary? >> > >> > In fact, who calls them? Certainly nothing in this patch set... >> > :) > In the main colo set (I'm looking at the February version) there > are calls to them, the 'stop_replication' is called at failover time. > > Here is I think the later version: > http://lists.nongnu.org/archive/html/qemu-devel/2015-03/msg05391.html I think the primary shouldn't do any I/O after failover (and the secondary should close the NBD server) so it is probably okay to ignore the removal for now. Inserting the filter dynamically is probably needed though. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |