Re: [Qemu-block] [PATCH v10 09/20] qcow: convert QCow to use QCryptoBlock for encryption

[Alberto Garcia]

On Fri 23 Jun 2017 06:24:08 PM CEST, Daniel P. Berrange wrote:
> This converts the qcow driver to make use of the QCryptoBlock
> APIs for encrypting image content. This is only wired up to
> permit use of the legacy QCow encryption format. Users who wish
> to have the strong LUKS format should switch to qcow2 instead.
>
> With this change it is now required to use the QCryptoSecret
> object for providing passwords, instead of the current block
> password APIs / interactive prompting.
>
>   $QEMU \
>     -object secret,id=sec0,filename=/home/berrange/encrypted.pw \
>     -drive file=/home/berrange/encrypted.qcow,encrypt.format=aes,\
>            encrypt.key-secret=sec0

I just realized that the property in the 'secret' object is called
'file', not 'filename'.

You can of course keep my R-b if you fix that.

Berto